[cricket-users] Another cricket-0.68 problem.

From: Matthew Stier (Matthew.Stier@tddny.fujitsu.com)
Date: Thu Jul 15 1999 - 16:39:42 PDT


From: Matthew Stier <Matthew.Stier@tddny.fujitsu.com>

After creating a subtree that used y-min and y-max to limit the scale of
the data being presented, I ran into a bug ing grapher.cgi.

I would click on a link to graph a page, and the images would not show.
Click on refresh to, and the would be loaded from cricket's cache. Upon
viewing my Netscape Enterprise server logs, I found that grapher.cgi was
hitting a problem near line 1290.

The cause of the problem, is that the variable $ym was getting defined,
even when the variable $ymax was not. I'm not sure how.

The fix, was to expand the outer if-statement to check the both $ym and
$ymax were defined. I also add the test to $ymin in the following block
of code.

$ diff -c grapher.cgi grapher.cgi.orig
*** grapher.cgi Thu Jul 15 18:28:11 1999
--- grapher.cgi.orig Thu Jul 15 19:29:42 1999
***************
*** 1290,1296 ****
                        my($ym);

                        $ym = graphParam($gRef, 'y-max', $ymax);
! if (! $ymaxlck && defined($ym) && defined($ymax)
) {
                                if ($ym > $ymax) {
                                        $ymax = $ym;
                                }
--- 1290,1296 ----
                        my($ym);

                        $ym = graphParam($gRef, 'y-max', $ymax);
! if (! $ymaxlck && defined($ym) ) {
                                if ($ym > $ymax) {
                                        $ymax = $ym;
                                }
***************
*** 1297,1303 ****
                        }

                        $ym = graphParam($gRef, 'y-min', $ymin);
! if (! $yminlck && defined($ym) && defined($ymin)
) {
                                if ($ym < $ymin) {
                                        $ymin = $ym;
                                }
--- 1297,1303 ----
                        }

                        $ym = graphParam($gRef, 'y-min', $ymin);
! if (! $yminlck && defined($ym) ) {
                                if ($ym < $ymin) {
                                        $ymin = $ym;
                                }

--
Matthew Lee Stier                  *  Fujitsu Network Communications
Unix Systems Administrator         |  Two Blue Hill Plaza
Ph: 914-731-2097 Fx: 914-731-2011  |  Sixth Floor
Matthew.Stier@fnc.fujitsu.com      *  Pearl River, NY 10965

--------------------------- ONElist Sponsor ----------------------------

The Best Place to Buy Movies - Reel.com <a href=" http://clickme.onelist.com/ad/reel1 ">Click Here</a>

------------------------------------------------------------------------



This archive was generated by hypermail 2b29 : Mon Mar 06 2000 - 19:00:56 PST