From: "Honermann Tom A." <TA.Honermann@hosp.wisc.edu>
I never got a response on this bug. If you didn't scroll down far enough,
please do so.
> -----Original Message-----
> From: Honermann Tom A. [SMTP:TA.Honermann@hosp.wisc.edu]
> Sent: Tuesday, January 11, 2000 12:38 PM
> To: 'Jeff Allen'; 'cricket-users@onelist.com'
> Subject: RE: [cricket-users] ugrading to cricket ver 0.71
>
> From: "Honermann Tom A." <TA.Honermann@hosp.wisc.edu>
>
> > But I don't agree with this one:
> [Honermann Tom A.] OK, let me take another shot at it:
>
> > Honermann Tom A. wrote:
> > > The fix: change line 1338 from
> > > if (defined($ymin) && $ymin > $ym) {
> > > to:
> > > if (defined($ymin) && $ymin < $ym) {
> >
> [Honermann Tom A.]
> This jumped out at me because the same comparison (>) is used at
> line 1324 and line 1333. These lines are used for finding the _largest_
> max
> and the _smallest_ min. The confusion comes in because the code embraced
> by
> the if is # nothing. As the code stands right now, it will select the
> largest y-min amongst a set of data sources. I have verified this.
>
> The fix above will work, but to enhance readability, I propose the
> block be changed as follows:
>
> Change lines 1322-1338 of grapher.cgi from:
> $ym = graphParam($gRef, 'y-max');
> if ($ym && ! $ymaxlck) {
> if (defined($ymax) && $ymax > $ym) {
> # nothing
> } else {
> $ymax = $ym;
> }
> }
>
> $ym = graphParam($gRef, 'y-min');
> if ($ym && ! $yminlck) {
> if (defined($ymin) && $ymin > $ym) {
> # nothing
> } else {
> $ymin = $ym;
> }
> }
> to:
> $ym = graphParam($gRef, 'y-max');
> if ($ym && ! $ymaxlck) {
> if (! defined($ymax) || $ym > $ymax) {
> $ymax = $ym;
> }
> }
>
> $ym = graphParam($gRef, 'y-min');
> if ($ym && ! $yminlck) {
> if (! defined($ymin) || $ym < $ymin) {
> $ymin = $ym;
> }
> }
>
> > In that line, ym is the one we just got fro the config tree. If we
> > have not yet set a global ymin, then we do so. If the global ymin we
> > last set is less than the current proposed one, then we ignore the
> > proposed one. Otherwise, we set the global one (ymin) to the proposed
> > one (ym).
> >
> > If I'm wrong, explain why, but for now I am leaving it.
> >
> > Thanks for your help!
> >
> > --
> > Jeff R. Allen | jra@corp.webtv.net
> > WebTV Service Engineering | http://www.munitions.com/~jra
>
> --------------------------- ONElist Sponsor ----------------------------
>
> Hey Freelancers: Find your next project through JobSwarm!
> You can even make money in your sleep by referring friends.
> <a href=" http://clickme.onelist.com/ad/jobswarm1 ">Click Here</a>
>
> ------------------------------------------------------------------------
--------------------------- ONElist Sponsor ----------------------------
Hey Freelancers: Find your next project through JobSwarm!
You can even make money in your sleep by referring friends.
<a href=" http://clickme.onelist.com/ad/jobswarm1 ">Click Here</a>
------------------------------------------------------------------------
This archive was generated by hypermail 2b29 : Mon Mar 06 2000 - 19:01:11 PST